Discussion:
[MacPorts] #57643: pulseaudio: Examine gtk3 dependency
MacPorts
2018-11-19 12:33:12 UTC
Permalink
#57643: pulseaudio: Examine gtk3 dependency
------------------------+------------------------
Reporter: ryandesign | Owner: Ionic
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port: pulseaudio
------------------------+------------------------
pulseaudio declares a library dependency on gtk3 (unless the minimal
variant is used). Is this really necessary? I see that it is using gtk3
headers at build time, but it does not appear to link to gtk3 libraries.
Would a build dependency be sufficient, or does it somehow still use gtk3
files at runtime?

I ask because pulseaudio's gtk3 dependency is the only remaining reason
why wine eventually depends on harfbuzz. wine must build universal, and as
of version 2, for the moment
[https://github.com/harfbuzz/harfbuzz/issues/1308 harfbuzz cannot build
universal anymore]. So at present I cannot update harfbuzz in MacPorts to
version 2 without making wine unbuildable. If pulseaudio didn't really
require gtk3 libraries at runtime, then pulseaudio could use
`depends_skip_archcheck-append gtk3` so that gtk3 and its dependencies
would not need to be installed universal.
--
Ticket URL: <https://trac.macports.org/ticket/57643>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-11-19 22:30:04 UTC
Permalink
#57643: pulseaudio: Examine gtk3 dependency
-------------------------+----------------------
Reporter: ryandesign | Owner: Ionic
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: pulseaudio |
-------------------------+----------------------

Comment (by Ionic):

Hmm, as far as I remember, some binaries used GTK3 in the past, like
`pavumeter`. Not sure if these binaries are still built, so yeah, maybe we
can drop the `gtk3` dependency. I'll have to investigate.
--
Ticket URL: <https://trac.macports.org/ticket/57643#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-12-01 02:44:38 UTC
Permalink
#57643: pulseaudio: Examine gtk3 dependency
-------------------------+----------------------
Reporter: ryandesign | Owner: Ionic
Type: defect | Status: assigned
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords:
Port: pulseaudio |
-------------------------+----------------------

Comment (by Ionic):

The only thing still using `gtk3` within PulseAudio is a `gtk-test`
utility.


I'll make it a `build` dependency (`test` wouldn't be appropriate).
--
Ticket URL: <https://trac.macports.org/ticket/57643#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-12-01 03:25:32 UTC
Permalink
#57643: pulseaudio: Examine gtk3 dependency
-------------------------+--------------------
Reporter: ryandesign | Owner: Ionic
Type: defect | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords:
Port: pulseaudio |
-------------------------+--------------------
Changes (by Mihai Moldovan <ionic@
>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"4b30d1de62b48b55ea2f89d6fb475e3c2313b50c/macports-ports"
4b30d1de62b48b55ea2f89d6fb475e3c2313b50c/macports-ports] (master):
{{{
#!ConfigurableCommitTicketReference repository="macports-ports"
revision="4b30d1de62b48b55ea2f89d6fb475e3c2313b50c"
audio/pulseaudio: update to 12.2 (no changes), drop gtk3 dependency.

GTK3 is currently only needed for a test program, but we don't even use
the testsuite currently. Can't move to depends_test, though, since the
test program is built with all other artifacts.

Also added some test code, but disabled for now. Adding check as an
unused general build-time dependency sounds like a bad idea.

Fixes: https://trac.macports.org/ticket/57643
}}}
--
Ticket URL: <https://trac.macports.org/ticket/57643#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...