Discussion:
[MacPorts] #56110: Travis: skip building ports from the obsolete PortGroup
MacPorts
2018-03-20 14:05:07 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
---------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Keywords: | Port:
---------------------------+------------------
Our buildbot setup skips building ports from the obsolete PortGroup, while
travis builds currently report a failure. Maybe we could skip building
those ports on Travis as well if it's not too complicated. The code should
already be in `mpbb`.

--
Ticket URL: <https://trac.macports.org/ticket/56110>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-03-29 18:44:38 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by l2dy):

`mpbb` checks for "already been built" packages, which is not desired on
Travis CI.

So we should re-implement
[https://github.com/macports/mpbb/blob/387064c27c616757509ec8462b72cfe512b228ad
/mpbb-list-subports#L62-L76 the obsolete check] in `mpbot-github` or
implement a switch in `mpbb` to disable this check and use `mpbb` for
listing subports.

--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-03-29 20:56:45 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by mojca):

Fix `mpbb`

--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-05-20 14:55:13 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by l2dy):

See https://github.com/macports/mpbb/pull/7.
--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-09-08 02:00:24 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by raimue):

In [changeset:"868f68814515c2af4dc4c4921b489b7ded410e99/mpbb"
868f68814515c2af4dc4c4921b489b7ded410e99/mpbb] (master):
{{{
#!ConfigurableCommitTicketReference repository="mpbb"
revision="868f68814515c2af4dc4c4921b489b7ded410e99"
mpbb-list-subports: Allow empty --archive-site

Passing an empty string to --archive-site disables the checks on the
remote mirror.

See: https://trac.macports.org/ticket/56110
}}}
--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-11-28 23:04:10 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by ryandesign):

The request to have mpbot use mpbb-list-subports is #57563. However, I may
`mpbb` checks for "already built" packages, which is not desired on
Travis CI.

By what means are we currently ensuring that prebuilt archives are not
used on Travis? I don't see that happening. I remember within the past
couple months we had a PR submitted which made a change to a port that
made it unbuildable, but because the port's version and revision were not
changed, Travis successfully downloaded the previously-built archive and
reported a successful build, so the PR got merged. (I don't remember what
port it was and can't find that PR again now.)

Or, is that what this PR is about? That we ''want'' Travis not to check
for preexisting archives, but it's not currently programmed to do that? If
so, then using mpbb-list-subports with empty --archive-site parameter
should be the solution.
--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-11-29 06:22:20 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by mojca):

I wanted to confirm that I observed the same issue: the port was
theoretically built on Travis, but it just fetched the existing binary
from our packages server and didn't actually do anything useful. I'm
pretty sure this wasn't intended and I assume that @l2dy didn't want this
to happen / wasn't aware this would happen. Do we have a ticket for that?
Post by MacPorts
The request to have mpbot use mpbb-list-subports is #57563.
Indeed, if we switch to `mpbb list-subports`, both this ticket and #57563
would be addressed at the same time.

Both tickets report two different problems which both arise from the same
decision / piece of code. Once that is fixed, both problems would be gone.
(Nitpicking: no ticket has the title "Switch to `mpbb`", so you could
equally well argue that ''this'' ticket is about switching to `mpbb`, just
way older :) :) :)
Post by MacPorts
Or, is that what this PR is about?
This ticket is precisely about what it says: it's annoying to get build
failures for obsolete ports. (I don't care how it's solved, it could of
course be done in `go`, but obviously switching to `mpbb` would address
the issue in probably the most elegant way.)
Post by MacPorts
That we want Travis not to check for preexisting archives, but it's not
currently programmed to do that? If so, then using mpbb-list-subports with
empty `--archive-site` parameter should be the solution.

* We want Travis to **actually** build all (sub)ports modified in a PR,
ideally in the same order as on the buildbot. Buildbot would skip building
pre-existing archives, Travis should not.
* We want Travis to fetch all dependencies (not modified in a PR) from a
server (ideally one also providing non-distributable binaries, which is
something you just work on, thanks a lot for that)
--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
MacPorts
2018-11-29 13:52:02 UTC
Permalink
#56110: Travis: skip building ports from the obsolete PortGroup
----------------------------+------------------
Reporter: mojca | Owner: l2dy
Type: defect | Status: new
Priority: Low | Milestone:
Component: buildbot/mpbb | Version:
Resolution: | Keywords:
Port: |
----------------------------+------------------

Comment (by l2dy):

I'm aware of the issues, but currently I'm too busy to work on them.
Hopefully I'll get more free time in a few weeks.
--
Ticket URL: <https://trac.macports.org/ticket/56110#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...