[MacPorts] #54064: port:mlt{, -qt5} : backported upstream patch, OpenCV & SDL tweaks

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
-------------------------+-------------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: haspatch | Port: mlt mlt-qt5
-------------------------+-------------------------
This patch introduces the following 4 enhancements (besides cleanup to
follow Qt5 changes):

- backports a fix from the next release that prevents crashing on exit in
dependents using the C++ MLT framework (Kdenlive)
- introduces a `gpl3` variant to enable some more features
- introduces an `opencv` variant to avoid opportunistic dependencies and
to formalise the fact that the choice of Qt version should match in OpenCV
and Melt .
- introduces a `disable_sdl` variant which can be useful when when Melt is
used in dependents that themselves depend on SDL2, like Kdenlive. This
will help avoid (warnings about) runtime conflicts which could lead to
unforeseen issues. It can be hoped that one day MLT will support SDL2 too.
I have not noticed any feature loss (in Kdenlive).

--
Ticket URL: <https://trac.macports.org/ticket/54064>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------
Changes (by RJVB):

* Attachment "patch-commit-a3188e3.diff" added.

backported upstream fix

--
Ticket URL: <https://trac.macports.org/ticket/54064>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------
Changes (by RJVB):

* Attachment "patch-no-sdl.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54064>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------
Changes (by RJVB):

* Attachment "mlt.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54064>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by RJVB):

On a related note: adding Movit support for hardware video processing
would be nice!
https://movit.sesse.net/

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by mf2k):

Please use the normal syntax for adding a {{{revision}}} line and not
append it to the {{{version}}} line. Also, {{{revision}}} should be 1, not
2, since it starts at 0.

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by RJVB):

I think Dan can handle those points if he agrees.

Me I think that adding the revision statement on the same line as the
version is the best and simplest protection against forgetting to remove
it; it also reads more in line with how the port effective version is
shown elsewhere. Both alternatives are valid syntax so I don't see why we
have to be splitting hairs over this.

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by ddennedy):

There is a lot of changes in here. Will you volunteer to be the new
maintainer of the mlt port?

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by RJVB):

Co/principal maintainer, sure, esp. of the Qt5 side of things. I don't
have commit rights so I'm not the most ideal candidate to take over
maintainership completely.

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------

Comment (by ddennedy):

I do not have commit access either, but I am ok with co-maintainer as
well.

--
Ticket URL: <https://trac.macports.org/ticket/54064#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS

[MacPorts]

#54064: port:mlt{,-qt5} : backported upstream patch, OpenCV & SDL tweaks
--------------------------+----------------------
Reporter: RJVB | Owner: (none)
Type: enhancement | Status: closed
Priority: Normal | Milestone:
Component: ports | Version:
Resolution: fixed | Keywords: haspatch
Port: mlt mlt-qt5 |
--------------------------+----------------------
Changes (by MarcusCalhoun-Lopez):

* status: new => closed
* resolution: => fixed


Comment:

I believe all of these proposals have been incorporated.\\
If not, please feel free to reopen.